fix(floating-big-letter): correct padding and positioning #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes inconsistent/incorrect padding
There is always at least one, empty line in a buffer. When replacing the range [0,0[, the new contents are inserted before said empty line. As of nvim 0.10, this results in the new contents being scrolled up by one row, breaking the vertical centering. Fix this by ensuring that the entire buffer content is overridden.
9ary
force-pushed
the
big-letter-fixes
branch
from
e677192 to
f75ec76
Compare
s1n7ax
approved these changes
Jan 10, 2025
|
@9ary Thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple small bugs with floating letter hints.
Before:
After:
